Skip to content

Conversation

@sharktrexer
Copy link
Contributor

Fix for #585
Alternative to #599

From suggestion 2: The chasing pet moves at the speed of it's friend - https://github.com/sharktrexer/vscode-pets/blob/main/src/panel/states.ts#L357-L367

Pets now use the slower friend's speed. I assumed it made more sense for only faster pets to move slower rather than slower pets moving faster. I can make a change for slower pets to keep with with faster pets if desired.

@sharktrexer sharktrexer changed the title The chasing pet moves at the speed of it's friend only if friend is slower The chasing pet moves at the speed of its friend only if friend is slower Sep 26, 2024
@sharktrexer
Copy link
Contributor Author

I had forgotten to run "npm run lint:fix" before. Now it should pass the lint test.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 18.50%. Comparing base (a177f0f) to head (a51e364).
Report is 398 commits behind head on main.

Files with missing lines Patch % Lines
src/panel/states.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
+ Coverage   17.06%   18.50%   +1.44%     
==========================================
  Files          25       31       +6     
  Lines        1260     1529     +269     
  Branches      167      199      +32     
==========================================
+ Hits          215      283      +68     
- Misses       1039     1236     +197     
- Partials        6       10       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sharktrexer
Copy link
Contributor Author

Hey @tonybaloney

It is been a couple weeks, so I am wondering if I could get an update on this being merged? If there are any other issues for this repo, related to this PR or not, I would love to contribute/help anyway I can.

Thank you for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants