fix: stylistic tweaks and fixes #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
(The big diff comes from |
velddev
reviewed
Sep 17, 2025
| const getStyle = (method, colorMode) => (colorMode === "dark" ? darkModeMappings : lightModeMappings)[method]; | ||
|
|
||
| const HeaderWrapper = styled.div` | ||
| border: 1px solid ${(props) => mappings[props.method].border}; |
Contributor
There was a problem hiding this comment.
Instead of using react, I would highly recommend using CSS variables which can be set in custom.css
e.g.
:root {
--header-border-style: 1px solid #c1e3d0;
}
[data-theme="dark"] {
--header-border-style: 1px solid #c9c9ee;
}
Contributor
There was a problem hiding this comment.
This may cause desync issues on the UI if we rely on the react hook
Contributor
Author
There was a problem hiding this comment.
Resolved. Already tested this one, should be identical.
velddev
reviewed
Sep 18, 2025
Comment on lines
-82
to
-88
| a { | ||
| color: unset; | ||
| text-decoration: underline; | ||
| } | ||
| a:hover { | ||
| color: unset; | ||
| opacity: 0.8; |
Contributor
Author
There was a problem hiding this comment.
I thought it would pop up more visually with those rules removed. This is what those rules do:
With those rules removed:
This is even less noticeable on light mode.
jpbberry
reviewed
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pull request is a toned down version of #100. This pull request focuses on the changes done to the documentation website on the visual side of things, such as:
deprecatedtag actually visible.manropefont to be consistent with the main website.