Open
Conversation
The logic that was used was different from the JS version; the JS version was more correct as just specifying UrlRootLocation would give proper results but would fail in the server-side version. In addition, a bug was fixed where the return value of QualifyUrl was being ignored.
Clean up: removed backup Moved everything to .NET 4.5 Added GitHub style ``` codeblocks, using the 'GitHubMode' option. Any identifier specified is used as language specification in the code block in the html Added test for GitHub mode Removed js project's post build event as it failed anyway.
various fixes in server-side Markdown.OnQualifyUrl
Author
|
Reopened, with bugfix in codeblocks for nohighlight |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added github style codeblock support, using a new GitHubCodeBlocks flag on the MarkdownDeep class. It allows specification of language after the first fence marker of a code block. This is then emitted into the HTML using Highlight.js style classes, so
will result in
I also merged a PR that's been dangling on your PR list for over a year, as it fixed a couple of problems. Not sure if this Repo is still alive or not.
There's flexibility in the language specification: you can have space between the fence marker and the language and also trailing spaces / tabs till the EOL.
I also removed the Backup folder as it was of no use
I also updated the gitignore file to fit vs.net usage
I also removed the postbuild event on the js project as it fails. It's also not really nice to run a .bat in a post-build on an OSS project, as it will take people off-guard: it might ruin their PC as it runs likely at Administrator level.
Hope helpful.