torch-activate: Never add the current directory to LD_LIBRARY_PATH #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dynamic loader parses a : at the end of LD_LIBRARY_PATH as a separator delimiting the empty string on its right, which is interpreted as the current directory. This can cause all kinds of hard-to-debug breakage and may be a security vulnerability in certain contexts. See: https://joshumax.github.io/general/2017/06/08/how-torch-broke-ls.html Correct this using the ${parameter:+word} syntax, which works in all POSIX shells: http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_06_02 Signed-off-by: Anders Kaseorg <andersk@mit.edu>
|
This looks like a much more compliant patch than the one I was going to send in a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic loader parses a
:at the end of LD_LIBRARY_PATH as a separator delimiting the empty string on its right, which is interpreted as the current directory. This can cause all kinds of hard-to-debug breakage and may be a security vulnerability in certain contexts. See:https://joshumax.github.io/general/2017/06/08/how-torch-broke-ls.html
Correct this using the
${parameter:+word}syntax, which works in all POSIX shells:http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_06_02