Skip to content

Accessibility audit - text layout fixes#419

Merged
helenb merged 5 commits intomainfrom
feature/text-layout-fixes
Mar 12, 2026
Merged

Accessibility audit - text layout fixes#419
helenb merged 5 commits intomainfrom
feature/text-layout-fixes

Conversation

@helenb
Copy link
Copy Markdown
Member

@helenb helenb commented Mar 3, 2026

Link to Ticket

Description of Changes Made

Various changes as a result of finding text layout issues both with the font-size settings adjusted, and when testing the default font-size at tablet size.

  • Reduce spacing between secondary nav columns at smaller font sizes to prevent issues with longer words being obscured when font size is increased
  • Tweak grid layout at tablet size for the key points block, to prevent issues with overlapping content when font-size is large
  • Tweak the image listing layout when the overall width is smaller, to prevent the case where the image is large and the text is really tall and thin.

How to Test

See https://docs.google.com/spreadsheets/d/1jEfzMuoz_gv5aA9sEraNkJL3Wzis41tHnuCKrWvE_H0/edit?gid=1992549741#gid=1992549741 for example pages to test (wherever it says 'Fix in progress'). Note the URLs on the sheet are on the production site, but if you pull the staging data you'll have a lot of them). It's useful to also pull the staging images to test the listing changes.

Screenshots

Expand to see more

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Performance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@helenb helenb changed the title Feature/text layout fixes Text layout fixes Mar 3, 2026
@helenb helenb changed the title Text layout fixes Accessibility audit - text layout fixes Mar 3, 2026
Comment thread tbx/static_src/sass/components/_listing-image.scss
Comment thread tbx/static_src/sass/components/_keypoints.scss Outdated
@chris-lawton
Copy link
Copy Markdown
Member

Thanks @helenb, left a couple of comments for review : )

@chris-lawton
Copy link
Copy Markdown
Member

Good to go!

helenb added 5 commits March 12, 2026 16:17
… prevent issues with longer words being obscured when font size is increased
…at a higher breakpoint. Avoids overlapping text with large font sizes and scans better for long titles.
…s with ovelapping content when text size is large
…f space is tight - avoids the text getting really cramped and overflowing the edge
@helenb helenb force-pushed the feature/text-layout-fixes branch from 7ba32cd to ce827d6 Compare March 12, 2026 16:18
@helenb helenb merged commit c75374c into main Mar 12, 2026
4 checks passed
@helenb helenb deleted the feature/text-layout-fixes branch March 12, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants