Include <string> tags for valid UTF-8 byte sequences
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13 +/- ##
===========================================
+ Coverage 99.19% 99.23% +0.03%
===========================================
Files 11 11
Lines 2618 2749 +131
===========================================
+ Hits 2597 2728 +131
Misses 21 21 ☔ View full report in Codecov by Sentry. |
josecelano
approved these changes
Nov 26, 2024
Member
josecelano
left a comment
josecelano
left a comment
There was a problem hiding this comment.
Hi @magecnion, thank you! Looks good. I will merge it when you set it as ready to review.
Comment on lines
+317
to
+320
| assert_eq!( | ||
| bencode_to_json_unchecked(b"00:"), | ||
| r#""<string></string>""#.to_string() | ||
| ); |
Member
There was a problem hiding this comment.
Hi @magecnion I have not thought about this case. Empty byte sequences could be mapped to hex of string tags. However, I prefer what you did. Since tags are mandatory and JSON uses UTF-8 I prefer to use the tag <string> for empty byte sequences.
Member
|
ACK 15e4584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<string>tags around valid UTF-8 byte sequences in the output.bencoded_string_with_repeated_bytefunction so it works with other lengths different from1000000.