-
Notifications
You must be signed in to change notification settings - Fork 57
refactor: next step #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kimyouknow
wants to merge
3
commits into
main
Choose a base branch
from
refactor/react-simplikit-next
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor: next step #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following hooks have been marked as deprecated due to their reliance on browser-specific APIs, as react-simplikit shifts focus to platform-independent, pure state/logic hooks: - useDoubleClick - useGeolocation - useImpressionRef - useIntersectionObserver - useLongPress - useOutsideClickEffect - useStorageState - useVisibilityEvent These hooks will be removed in a future major version.
Reposition react-simplikit as a Universal Hook Library focused on platform-independent, pure state/logic hooks. Maintain backward compatibility for existing hooks like `useToggle` and `usePrevious`, while deprecating browser/platform-dependent hooks such as `useGeolocation` and `useDoubleClick`, which will not receive new features and may be removed in future versions.
…c hooks Updated the README to emphasize that react-simplikit will exclusively support platform-independent pure state/logic hooks, while deprecating browser/platform-dependent hooks. Ensured backward compatibility for existing hooks and outlined the ongoing maintenance plan for the library.
Contributor
|
Size Change: 0 B Total Size: 65.5 kB ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 1093 1093
Branches 324 324
=========================================
Hits 1093 1093 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Checklist
yarn run fixto format and lint the code and docs?yarn run test:coverageto make sure there is no uncovered line?