Open
Conversation
farnyser
force-pushed
the
attached-trigger-orders
branch
from
d950089 to
5dec806
Compare
antazoey
approved these changes
Feb 23, 2026
|
|
||
| @model_serializer | ||
| def serialize_model(self) -> dict[str, dict[str, Any] | str]: | ||
| if self.parent_order_id is not None: |
Collaborator
There was a problem hiding this comment.
this is exclude_none=True kwarg on model dump, just as fyi
also can simplify this
data = {"trigger": self.trigger.serialize_model()}
if self.parent_order_id is not None:
data["parent_order_id"] = self.parent_order_id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.