Add support for AF_UNIX socket connections#416
Closed
chancerussell wants to merge 2 commits intotpope:masterfrom
Closed
Add support for AF_UNIX socket connections#416chancerussell wants to merge 2 commits intotpope:masterfrom
chancerussell wants to merge 2 commits intotpope:masterfrom
Conversation
We need a way to let the user indicate that they want a AF_UNIX socket connection. I don't have the Vimscript skills to plumb in an alternate connection command and function, so here's a simple, dumb proof of concept: if the user passes a string starting with nrepl+unix:, we'll pass that string unmodified as the host value when we call the Python script.
Proof of concept. Punting on adding a cleaner path for signaling that the user wants to connect to such a server in favor of the dumbest thing that could work: if the input host string starts with `nrepl+unix:`, use the rest of the string as the socket path.
Author
|
Closed in favor of #418 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #417.
A draft for adding support for connecting to AF_UNIX domain socket nREPL servers (the type that nREPL starts when you provide the
--socket PATHoption).If the user calls
FireplaceConnectwith a string starting withnrepl+unix:, we'll take the remainder of the string as a path to the domain socket and create a Python socketThis is a proof of concept—I imagine we'd like to do something more elegant than a "magic string prefix" to allow users to ask for such a connection and for the Vimscript portion of the plugin to tell the Python portion to initiate one, but we're already pushing up against the limits of my Vimscript and Python skills :)