Use the shell less to avoid any shell metacharacter shenanigans#19
Open
cvrebert wants to merge 5 commits intotravis-ci:masterfrom
cvrebert:less-shell
Open
Use the shell less to avoid any shell metacharacter shenanigans#19cvrebert wants to merge 5 commits intotravis-ci:masterfrom cvrebert:less-shell
cvrebert wants to merge 5 commits intotravis-ci:masterfrom
cvrebert:less-shell
Conversation
Author
|
@BanzaiMan Ping |
| @fetch_tar = File.expand_path('fetch.tgz', @casher_dir) if path_ext(url) == 'tgz' | ||
|
|
||
| if system "curl --tcp-nodelay -w '#{CURL_FORMAT}' %p -o %p -f -s --retry 3 >#{@casher_dir}/fetch.log 2>#{@casher_dir}/fetch.err.log" % [url, @fetch_tar] | ||
| args = ['curl', '--tcp-nodelay', '-w', CURL_FORMAT, '-o', @fetch_tar, '-f', '-s', '--retry', '3', url] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Sorry for the delay. I like the idea, but there may be some issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general, shelling out is relatively error-prone given that one must remember to escape/quote shell metacharacters all the time, including spaces in filenames. For these
curlandtarcommands, there's no need to be using the shell in the first place, since no shell features are being used. So this switches them to useOpen3.popen3with an array argument instead (which shouldn't invoke the shell).Also, the old code used
%pfor some shell escaping, even thoughString#inspectis not intended to be used for that purpose.Since travis-ci/travis-ci#5092 involves Cacher, I'm looking for possible bugs in Cacher.