Conversation
|
This PR might annul the existing caches with absolute paths, so we should test that. |
|
I think the issue #45 attempts to solve is |
native-api
left a comment
native-api
left a comment
There was a problem hiding this comment.
LGTM.
-l seems not really necessary since we compare files in the same environment but I guess it won't hurt -- and the output would look better with the paths looking as the user specified.
| # paths=$(expand_path "$@") | ||
| paths="$@" |
There was a problem hiding this comment.
On closer inspection:
travis_build stock logic that uses ~ for cache paths will become broken since Bash won't expand it in $(checksum_checker) invocation:
$ paths="~ C:\\"
$ md5deep64 ${paths}
C:\Users\Sasha\~: No such file or directory
C:\: Is a directory
There was a problem hiding this comment.
The changes also need to be duplicated into Ruby version since it's used in preference to Bash version if RVM is available.
2 participants
Allow relative paths to be passed.
This effectively reverts #45.
I do not quite remember the rationale for #45, to be honest, but I believe that some relative paths didn't work so well before. This PR adds
-linstead, which might be a good solution to the problem.