minor updates

[superjustin]

No description provided.

[coveralls]

Coverage remained the same when pulling afabef3 on superjustin:remote into 1c8fd4c on travishaynes:master.

[travishaynes]

Thanks. I'm working on updating the FedEx service right now. After I push those changes I'll pull this code in as well.

[superjustin]

awesome 👍

[coveralls]

Coverage decreased (-0.28%) when pulling 79368d2 on superjustin:remote into 1c8fd4c on travishaynes:master.

[superjustin]

commit 79368d2 includes fedex match

[travishaynes]

I could be mistaken, but I don't believe that FedEx uses 12 digit tracking numbers in production mode. I've added these additional package ID matchers so far in my working copy of the gem (which include the 12 digit numbers, but I'm not certain it's completely necessary):

/(\b96\d{20}\b)|(\b\d{15}\b)|(\b\d{12}\b)/ 
/\b((98\d\d\d\d\d?\d\d\d\d|98\d\d) ?\d\d\d\d ?\d\d\d\d( ?\d\d\d)?)\b/ 

[superjustin]

do you get this error on fedex? "TypeError: can't convert Symbol into Integer"

details = Trackerific::Services::FedEx.track('183689015000001')
SOAP request: https://wsbeta.fedex.com/web-services/track
SOAPAction: "http://fedex.com/ws/track/v8/track", Content-Type: text/xml;charset=UTF-8, Content-Length: 1140

env:Bodyns:TrackRequestns:WebAuthenticationDetailns:UserCredentialns:KeyCpjTiYSvbjD0TaNj/ns:Keyns:PasswordgCkFkYtfBznjI3VQquJRbjUtK/ns:Password/ns:UserCredential/ns:WebAuthenticationDetailns:ClientDetailns:AccountNumber494881268/ns:AccountNumberns:MeterNumber118588465/ns:MeterNumber/ns:ClientDetailns:TransactionDetailns:CustomerTransactionIdTrackerific/ns:CustomerTransactionId/ns:TransactionDetailns:Versionns:ServiceIdtrck/ns:ServiceIdns:Major8/ns:Majorns:Intermediate0/ns:Intermediatens:Minor0/ns:Minor/ns:Versionns:SelectionDetailsns:CarrierCodeFDXE/ns:CarrierCodens:PackageIdentifierns:TypeTRACKING_NUMBER_OR_DOORTAG/ns:Typens:Value183689015000001/ns:Value/ns:PackageIdentifier/ns:SelectionDetailsns:ProcessingOptionsINCLUDE_DETAILED_SCANS/ns:ProcessingOptions/ns:TrackRequest/env:Body/env:Envelope

HTTPI POST request to wsbeta.fedex.com (httpclient)
SOAP response (status 200)
<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/">SOAP-ENV:Header/SOAP-ENV:BodySUCCESSSUCCESStrck0Request was successfully processed.Request was successfully processed.Trackerifictrck800SUCCESSSUCCESStrck0Request was successfully processed.Request was successfully processed.falsefalse0ERRORtrck9040No information for the following shipments has been received by our system yet. Please try again or contact Customer Service at 1.800.Go.FedEx(R) 800.463.3339.No information for the following shipments has been received by our system yet. Please try again or contact Customer Service at 1.800.Go.FedEx(R) 800.463.3339.183689015000001false0000INDIRECT_SIGNATURE_RELEASEINELIGIBLEREDIRECT_TO_HOLD_AT_LOCATIONINELIGIBLEREROUTEINELIGIBLERESCHEDULEINELIGIBLE/SOAP-ENV:Body/SOAP-ENV:Envelope
TypeError: can't convert Symbol into Integer

[zackshapiro]

@travishaynes @superjustin How is the progress on this? Getting this merged in would be really helpful right about now with the project I'm working on

[superjustin]

Hi @zackshapiro , until it gets merged in, you can pull it from my repository.

[travishaynes]

Hey guys, sorry I haven't got to this sooner. I had a PC meltdown last week, and have been waiting for some replacement parts. I'll take a look at this as soon as I can and get it merged soon. Like @superjustin said, you can just pull from his repository until then, but it shouldn't be too long. I have been making some heavy changes to the FedEx service that may effect this. Apparently FedEx reuses their tracking IDs, which is something I didn't account for.

[coveralls]

Coverage decreased (-0.58%) when pulling 80269d2 on superjustin:remote into 1c8fd4c on travishaynes:master.