[green] USPS tracking now working#9
Open
zackshapiro wants to merge 2 commits intotravishaynes:masterfrom
zackshapiro:0.7.6
Open
[green] USPS tracking now working#9zackshapiro wants to merge 2 commits intotravishaynes:masterfrom zackshapiro:0.7.6
zackshapiro wants to merge 2 commits intotravishaynes:masterfrom
zackshapiro:0.7.6
Conversation
rewrote location to include multiple word locations like 'san francisco' or 'los angeles'
Author
|
@travishaynes Bumping this |
Author
|
Any action on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datemethod that was the source of many failures. The thing that was causing the error was a hardcoded look for a certain range. With the re-write, it looks for the month in the array and uses it's index as the starting value for the date. It then goes either 2 or 4 places deeper in the array to get the full date based on whether AM or PM is present in that index.descriptionmethod to detect the description more simply. The format is always a description, followed by a comma, so I'm just splitting on the first comma. Tried this with a few data sets, works well. They never use commas in the descriptionlocationmethod, detecting whether or not the location is present. If not, returning an empty string for location.