Refactor to typescript, modern tools #49
Open
chiefidiot wants to merge 0 commit intotrevoro:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I assume this is DOA given the comment in the README:
Since it changes some of the core APIs, if didn't want to do a major version bump, it would need to be a different package. Some of the design choices (eg. preference for functional over OOO) aren't compatible. For the moment I renamed it
denameand published it that way for a project, however wanted to throw it back to see if there is any desire to incorporate it into the original project.Future goals are creating some pluggable components, like a db connector, recursor, zone file parser, etc. as separate packages.