Skip to content

Conversation

@ryanntannn
Copy link

sitespeedio/graphite:0.9.14 image is using a deprecated docker image format, causing sample docker compose to fail:

 ⠴ benchto-graphite Pulling                                                                                                                              4.6s 
Docker Image Format v1 and Docker Image manifest version 2, schema 1 support has been removed. Suggest the author of docker.io/sitespeedio/graphite:0.9.14 to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/
`docker-compose` process finished with exit code 1

this PR updates docker compose images to sitespeedio/graphite:1.1.10-5 and grafana/grafana:12.1.1, and removed the deprecated version property.

@cla-bot
Copy link

cla-bot bot commented Sep 8, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ryanntannn ryanntannn marked this pull request as ready for review September 8, 2025 17:22
@ryanntannn
Copy link
Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Sep 18, 2025
@cla-bot
Copy link

cla-bot bot commented Sep 18, 2025

The cla-bot has been summoned, and re-checked this pull request!

@ryanntannn ryanntannn requested a review from Copilot September 18, 2025 01:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates docker-compose configuration to resolve deprecated image format issues and modernize dependencies. The PR upgrades Grafana and Graphite Docker images to more recent versions and removes the deprecated version property from docker-compose.yml.

  • Updated Graphite image from deprecated 0.9.14 to 1.1.10-5
  • Updated Grafana image from 4.1.2 to 12.1.1
  • Removed deprecated version: '2' property from docker-compose.yml

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
benchto-service-docker/docker-compose.yml Updates Docker image versions and removes deprecated version property
benchto-service-docker/config/graphite/storage-schemas.conf Updates retention configuration syntax from 1min to 1m

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant