Skip to content

Add dynamic schema support based on protobuf descriptor #27137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add dynamic schema support based on protobuf descriptor #27137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...ormats/src/main/java/io/trino/hive/formats/line/protobuf/ProtobufDeserializerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
public class ProtobufDeserializerFactory
implements LineDeserializerFactory
{
public static final String SERIALIZATION_CLASS = "serialization.class";
private LoadingCache<String, Descriptor> cache;

public ProtobufDeserializerFactory(Path descriptorsDirectory, Duration updateInterval, long maximumSize)
Expand Down Expand Up @@ -80,15 +81,20 @@ public ProtobufDeserializer create(List<Column> columns, Map<String, String> ser
throw new TrinoException(CONFIGURATION_INVALID, "No \"hive.protobufs.descriptors\" set in hive configuration");
}

String serializationClass = serdeProperties.get("serialization.class");
String serializationClass = serdeProperties.get(SERIALIZATION_CLASS);
if (serializationClass == null) {
throw new TrinoException(HIVE_INVALID_METADATA, "Missing serdeproperties key \"serialization.class\"");
}
else if (!serializationClass.matches("^[^$]+\\$[^$]+$")) {
throw new TrinoException(HIVE_INVALID_METADATA, String.format("Expected serialization.class to contain {package}${protoname}, but was %s", serializationClass));
}

return new ProtobufDeserializer(columns, cache.getUnchecked(serializationClass));
return new ProtobufDeserializer(columns, getDescriptor(serializationClass));
}

public Descriptor getDescriptor(String serializationClass)
{
return cache.getUnchecked(serializationClass);
}

private static class DescriptorCacheLoader
Expand Down
Loading
Loading