-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs: correct model management #8562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This change improves the model management documentation. Explicitily explains that models should be unloaded before being reloaded when using EXPLICIT mode.
| - Changes to the model repository while the server is running will be ignored. | ||
| Model load and unload requests using the [model control protocol](../protocol/extension_model_repository.md) will have no affect and will return an error response. | ||
|
|
||
| - This model control mode is selected by specifying `--model-control-mode=none` when starting Triton. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - This model control mode is selected by specifying `--model-control-mode=none` when starting Triton. | |
| - This model control mode is selected by specifying `--model-control-mode` when starting Triton. |
| This model control mode is selected by specifying `--model-control-mode=none` when starting Triton. | ||
| This is the default model control mode. | ||
| Changing the model repository while Triton is running must be done carefully, as explained in [Modifying the Model Repository](#modifying-the-model-repository). | ||
| - This is the default model control mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - This is the default model control mode. | |
| - The default model control mode is `--model-control-mode=none`. |
| - This is the default model control mode. | ||
|
|
||
| > [!IMPORTANT] | ||
| > Changing the model repository while Triton is running must be done carefully, as explained in [Modifying the Model Repository](#modifying-the-model-repository). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should remove duplicated warnings in the following sections.
This change improves the model management documentation.
Explicitly explains that models should be unloaded before being reloaded when using EXPLICIT mode.
TRI-249