refactor: use the built-in max/min to simplify the code#1672
refactor: use the built-in max/min to simplify the code#1672MicBun merged 3 commits intotrufnetwork:mainfrom
Conversation
Signed-off-by: nuxtreact <nuxtreact@outlook.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughConsolidates conditional clamping into single Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan for PR comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Time Submission Status
You can submit time with the command. Example: See available commands to help comply with our Guidelines. |
|
hi @nuxtreact, sorry for the late merge and the late reply, thank you for the contribution! |
Description
In Go 1.21, the standard library includes built-in max/min function, which can greatly simplify the code.
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
Checklist Explanation:
How to Review this PR:
Additional Information:
Summary by CodeRabbit