Skip to content

chore: new genesis with initial height#62

Merged
outerlook merged 1 commit intomainfrom
newGenesis
Jul 22, 2025
Merged

chore: new genesis with initial height#62
outerlook merged 1 commit intomainfrom
newGenesis

Conversation

@MicBun
Copy link
Member

@MicBun MicBun commented Jul 22, 2025

Description

Related Problem

resolves: https://github.com/trufnetwork/truf-network/issues/802

How Has This Been Tested?

I will test after the network is up and have created snapshot

Summary by CodeRabbit

  • Chores
    • Updated network genesis configuration with a new initial blockchain height and state hash.
    • Modified validator setup, now including only a single validator.

@MicBun MicBun requested a review from outerlook July 22, 2025 14:36
@MicBun MicBun self-assigned this Jul 22, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jul 22, 2025

Walkthrough

The genesis configuration file for the network was updated to set the initial blockchain height to 148618, remove one validator (leaving only one), and introduce a new state_hash field. Other configuration fields remain unchanged.

Changes

File(s) Change Summary
configs/network/v2/genesis.json Updated initial height, reduced validators to one, added state_hash

Estimated code review effort

1 (~2 minutes)

Poem

A single validator stands tall and bright,
Genesis height climbs to a brand new height.
A state hash appears, all shiny and new—
The network’s reborn, with much less to do.
Rabbits rejoice as the blocks take flight!
🐇✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@holdex
Copy link

holdex bot commented Jul 22, 2025

Time Submission Status

Member Status Time Action Last Update
MicBun ✅ Submitted 5h Update time Jul 23, 2025, 3:04 AM
@outerlook ❌ Missing - ⚠️ Submit time -

@MicBun MicBun marked this pull request as ready for review July 22, 2025 17:34
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
configs/network/v2/genesis.json (1)

5-11: Single-validator genesis is a SPOF

Reducing the validator set to one key removes any safety margin: downtime or key loss halts the entire chain. If this is only for a private or bootstrap network that’s fine; otherwise add ≥ 2 federated validators or enable dynamic validator-set updates before main-net launch.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a28927d and 91b4c29.

📒 Files selected for processing (1)
  • configs/network/v2/genesis.json (1 hunks)
🔇 Additional comments (2)
configs/network/v2/genesis.json (2)

12-12: Verify new state_hash field parsing in genesis loader

Our automated search did not locate the code that loads/parses the genesis file—please manually confirm that the new state_hash field is handled correctly to avoid unknown‐field errors. Specifically, ensure that the loader either:

  • Adds a StateHash string json:"state_hash"`` field to the Genesis struct, or
  • Decodes the raw JSON into a map[string]any (or otherwise disables DisallowUnknownFields) so unknown fields don’t cause a failure.

3-3: File: configs/network/v2/genesis.json
Lines: 3-3

  "initial_height": 148618,

Confirm node software supports non-zero initial_height

I searched the repo for any remaining zero-height assumptions and only found an archived staging genesis at configs/network/staging/old/old-genesis.json with "initial_height": 0. No Go, Rust or TypeScript code enforces a zero initial height.

• Ensure your Tendermint/CometBFT binary (and any accompanying tooling) is on a release that supports non-zero genesis heights. Older versions hard-code initial_height = 0 and will fail to start when presented with a non-zero value.

@outerlook outerlook merged commit 7fe2db8 into main Jul 22, 2025
4 of 5 checks passed
@outerlook outerlook deleted the newGenesis branch July 22, 2025 18:29
@coderabbitai coderabbitai bot mentioned this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants