Conversation
WalkthroughThe genesis configuration file for the network was updated to set the initial blockchain height to 148618, remove one validator (leaving only one), and introduce a new Changes
Estimated code review effort1 (~2 minutes) Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Time Submission Status
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
configs/network/v2/genesis.json (1)
5-11: Single-validator genesis is a SPOFReducing the validator set to one key removes any safety margin: downtime or key loss halts the entire chain. If this is only for a private or bootstrap network that’s fine; otherwise add ≥ 2 federated validators or enable dynamic validator-set updates before main-net launch.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
configs/network/v2/genesis.json(1 hunks)
🔇 Additional comments (2)
configs/network/v2/genesis.json (2)
12-12: Verify newstate_hashfield parsing in genesis loaderOur automated search did not locate the code that loads/parses the genesis file—please manually confirm that the new
state_hashfield is handled correctly to avoid unknown‐field errors. Specifically, ensure that the loader either:
- Adds a
StateHash stringjson:"state_hash"`` field to the Genesis struct, or- Decodes the raw JSON into a
map[string]any(or otherwise disablesDisallowUnknownFields) so unknown fields don’t cause a failure.
3-3: File: configs/network/v2/genesis.json
Lines: 3-3"initial_height": 148618,Confirm node software supports non-zero
initial_heightI searched the repo for any remaining zero-height assumptions and only found an archived staging genesis at
configs/network/staging/old/old-genesis.jsonwith"initial_height": 0. No Go, Rust or TypeScript code enforces a zero initial height.• Ensure your Tendermint/CometBFT binary (and any accompanying tooling) is on a release that supports non-zero genesis heights. Older versions hard-code
initial_height = 0and will fail to start when presented with a non-zero value.
Description
Related Problem
resolves: https://github.com/trufnetwork/truf-network/issues/802
How Has This Been Tested?
I will test after the network is up and have created snapshot
Summary by CodeRabbit