Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .trunk/configs/.isort.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[settings]
profile=black
2 changes: 2 additions & 0 deletions .trunk/configs/.markdownlint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Prettier friendly markdownlint config (all formatting rules disabled)
extends: markdownlint/style/prettier
7 changes: 7 additions & 0 deletions .trunk/configs/.shellcheckrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
enable=all
source-path=SCRIPTDIR
disable=SC2154

# If you're having issues with shellcheck following source, disable the errors via:
# disable=SC1090
# disable=SC1091
7 changes: 7 additions & 0 deletions .trunk/configs/.yamllint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
rules:
quoted-strings:
required: only-when-needed
extra-allowed: ["{|}"]
key-duplicates: {}
octal-values:
forbid-implicit-octal: true
5 changes: 5 additions & 0 deletions .trunk/configs/ruff.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Generic, formatter-friendly config.
select = ["B", "D3", "E", "F"]

# Never enforce `E501` (line length violations). This should be handled by formatters.
ignore = ["E501"]
39 changes: 6 additions & 33 deletions linters/buf/plugin.yaml
Original file line number Diff line number Diff line change
@@ -1,36 +1,9 @@
version: 0.1
lint:
# TODO(Tyler): This should be its own tool if we can avoid the eponymous pitfall
downloads:
- name: buf
version: 1.0.0-rc11
executable: true
downloads:
# macos arm64 was introduced after this version.
- os: macos
version: <0.42.0
url: https://github.com/bufbuild/buf/releases/download/v${version}/buf-Darwin-x86_64
- os:
linux: Linux
cpu:
x86_64: x86_64
arm_64: aarch64
url: https://github.com/bufbuild/buf/releases/download/v${version}/buf-${os}-${cpu}
- os:
macos: Darwin
cpu:
x86_64: x86_64
arm_64: arm64
url: https://github.com/bufbuild/buf/releases/download/v${version}/buf-${os}-${cpu}
- os: windows
cpu:
x86_64: x86_64
arm_64: arm64
url: https://github.com/bufbuild/buf/releases/download/v${version}/buf-Windows-${cpu}.exe
definitions:
- name: buf-format
files: [proto]
download: buf
tools: [buf]
suggest_if: never
description: Formatter for Protobuf
commands:
Expand All @@ -55,14 +28,14 @@ lint:
- buf.lock
- buf.gen.yaml
- buf.work.yaml
known_good_version: 1.17.0 # format subcommand was added in 1.2.0
known_good_version: 1.55.1 # format subcommand was added in 1.2.0
version_command:
parse_regex: ${semver}
run: buf --version

- name: buf-lint
files: [proto]
download: buf
tools: [buf]
description: Accelerate Protobuf development with Buf
commands:
- name: lint
Expand All @@ -83,14 +56,14 @@ lint:
- buf.gen.yaml
- buf.work.yaml
issue_url_format: https://docs.buf.build/lint/rules#{}
known_good_version: 1.17.0 # newer version is needed to support Windows fully
known_good_version: 1.55.1 # newer version is needed to support Windows fully
version_command:
parse_regex: ${semver}
run: buf --version

- name: buf-breaking
files: [proto]
download: buf
tools: [buf]
suggest_if: never
description: Check for breaking Protobuf API changes
commands:
Expand Down Expand Up @@ -118,7 +91,7 @@ lint:
- buf.gen.yaml
- buf.work.yaml
issue_url_format: https://docs.buf.build/breaking/rules#{}
known_good_version: 1.5.0
known_good_version: 1.55.1
version_command:
parse_regex: ${semver}
run: buf --version
55 changes: 0 additions & 55 deletions linters/buf/test_data/buf_breaking_v1.32.0_dupFile.check.shot

This file was deleted.

43 changes: 0 additions & 43 deletions linters/buf/test_data/buf_breaking_v1.5.0_basic.check.shot

This file was deleted.

54 changes: 0 additions & 54 deletions linters/buf/test_data/buf_breaking_v1.5.0_dupFile.check.shot

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
// trunk-upgrade-validation:RELEASE

exports[`Testing linter buf-breaking test basic 1`] = `
{
Expand Down
43 changes: 0 additions & 43 deletions linters/buf/test_data/buf_breaking_v1.9.0_basic.check.shot

This file was deleted.

14 changes: 0 additions & 14 deletions linters/buf/test_data/buf_format_v1.32.0_buf_lint.fmt.shot

This file was deleted.

Loading
Loading