Sourcery refactored master branch #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-139
to
+143
| if os.path.isdir(link_pathname): | ||
| if not os.listdir(link_pathname): | ||
| print("Removing empty directory '{0}'.".format(link_pathname)) | ||
| if not args.dryrun: | ||
| os.rmdir(link_pathname) | ||
| return | ||
| if os.path.isdir(link_pathname) and not os.listdir(link_pathname): | ||
| print("Removing empty directory '{0}'.".format(link_pathname)) | ||
| if not args.dryrun: | ||
| os.rmdir(link_pathname) | ||
| return |
Author
There was a problem hiding this comment.
Function clean_link refactored with the following changes:
- Merge nested if conditions (
merge-nested-ifs)
Comment on lines
-555
to
+559
| if output.find("does not exist on channel") != -1: | ||
| if args.verbose: | ||
| print("Key binding '{0}' already removed.".format(binding)) | ||
| else: | ||
| if output.find("does not exist on channel") == -1: | ||
| print("Removing key binding '{0}'.".format(binding)) | ||
| run_command(args, cmdargs + ["--reset"]) | ||
|
|
||
| elif args.verbose: | ||
| print("Key binding '{0}' already removed.".format(binding)) |
Author
There was a problem hiding this comment.
Function xfwm4_remove_key_binding refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches) - Merge else clause's nested if statement into elif (
merge-else-if-into-elif)
Comment on lines
-853
to
854
| args.is_xwindows = ( | ||
| exe_in_path("xterm") and | ||
| not (args.is_cygwin or args.is_windows) | ||
| exe_in_path("xterm") and not args.is_cygwin and not args.is_windows | ||
| ) | ||
|
|
Author
There was a problem hiding this comment.
Function main refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan)
| """ | ||
| pathname = os.path.join(xdg_cache_home, "python", "history") | ||
| return pathname | ||
| return os.path.join(xdg_cache_home, "python", "history") |
Author
There was a problem hiding this comment.
Function _history_pathname refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
| return False | ||
|
|
||
| return True | ||
| return not any(fnmatch.fnmatch(filename, glob) for glob in globs) |
Author
There was a problem hiding this comment.
Function ignore_file refactored with the following changes:
- Use any() instead of for loop (
use-any)
Comment on lines
+73
to
-75
| elif filename in svnignore_data: | ||
| continue | ||
| else: | ||
| if filename in svnignore_data: | ||
| continue |
Author
There was a problem hiding this comment.
Function main refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Merge else clause's nested if statement into elif (
merge-else-if-into-elif)
Comment on lines
-69
to
+76
| if arg == "-": | ||
| text = sys.stdin.read() | ||
| else: | ||
| text = open(arg, "rb").read() | ||
| text = sys.stdin.read() if arg == "-" else open(arg, "rb").read() | ||
| utext = text.decode("utf8") | ||
| utext = unicodedata.normalize("NFKD", utext) | ||
| utext = utext.translate(XTABLE) | ||
| try: | ||
| utext.encode("ascii", "strict") | ||
| except UnicodeEncodeError as err: | ||
| if arg == "-": | ||
| errfile = "" | ||
| else: | ||
| errfile = "In '%s', " % arg | ||
| errfile = "" if arg == "-" else "In '%s', " % arg |
Author
There was a problem hiding this comment.
Function main refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
sourcery-ai
bot
force-pushed
the
sourcery/master
branch
from
d1178d7 to
69b9be6
Compare
Author
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.02%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!