Fix selector resolution with async KiCad footprints

[Aqil-Ahmad]

Fixes tscircuit/tscircuit#1149
/claim tscircuit/tscircuit#1149

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
tscircuit-core-benchmarks	Ready	Preview	Comment	Oct 25, 2025 10:36am

[Aqil-Ahmad]

@seveibar can you please review!

[seveibar]

Too complex, lots of repeated code. Good first attempt

[Aqil-Ahmad]

Too complex, lots of repeated code. Good first attempt

i will try to simplify it and remove the redundancies (maybe with helper functions)

[seveibar]

remove

[seveibar]

A bit complex still since you're relying on a rerender. Did you check if asyncPhaseDependencies can handle this? Seems to me like it would?

[seveibar]

And don't test the baseline, there are hundreds of tests for that. Plus we have a rule one test per file

[Aqil-Ahmad]

Did you check if asyncPhaseDependencies can handle this? Seems to me like it would?

you're right! but i think asyncPhaseDependencies alone wont work. this only checks a component's own tree. since R1 and trace are siblings, we will have to look from root - the render system itself would need to be modified.

[Aqil-Ahmad]

Did you check if asyncPhaseDependencies can handle this? Seems to me like it would?

you're right! but i think asyncPhaseDependencies alone wont work. this only checks a component's own tree. since R1 and trace are siblings, we will have to look from root - the render system itself would need to be modified.

@seveibar what do you suggest?

[seveibar]

i think asyncPhaseDependencies alone wont work. this only checks a component's own tree. since R1 and trace are siblings, we will have to look from root - the render system itself would need to be modified.

Hmm interesting, i think it should check the entire tree and look from root. The intent with those dependencies was to make the entire system wait and not let certain parts of the tree move forward.

There's an exception for subcircuits which are supposed to be able to independently render but we can ignore that for now

[seveibar]

@Aqil-Ahmad nice insights

[seveibar]

@Aqil-Ahmad you seem to understand the code pretty well, definitely reach out to me on discord if you're interested in doing more work together: https://tscircuit.com/join

[Aqil-Ahmad]

Hmm interesting, i think it should check the entire tree and look from root. The intent with those dependencies was to make the entire system wait and not let certain parts of the tree move forward.

Hi @seveibar! can you please review.