Create Convert-Sorted-List-to-Binary-Search-Tree.md#15
Open
tshimosake wants to merge 2 commits intomasterfrom
Open
Create Convert-Sorted-List-to-Binary-Search-Tree.md#15tshimosake wants to merge 2 commits intomasterfrom
tshimosake wants to merge 2 commits intomasterfrom
Conversation
Owner
Author
|
ほかの方のPRをよく見ると参照しているPRの数が4,5くらいである一方、私は一つ二つ見て満足してしまっているので改めたい... |
nodchip
reviewed
Jun 1, 2025
| # 再帰ケース | ||
| mid = len(nums) // 2 | ||
| res = TreeNode(nums[mid]) | ||
| res.left = self.sortedArrayToBST(nums[:mid]) |
There was a problem hiding this comment.
スライスを作るとコピーが発生し、処理が重くなります。範囲のインデックスを渡すようにすると、処理が軽くなると思います。
oda
reviewed
Jun 1, 2025
| return res | ||
| ``` | ||
|
|
||
| 2回目。特に直すところは思いつかなかったので省略する（mid を mid_index にしてもよいが、好みの範囲か）。 |
There was a problem hiding this comment.
名前はいいですが、スライスを取るとコピーが作られるというのは意識してもいいでしょう。
完走した人から気に入ったコードを書く人を少し見繕っておくといいかと思いますよ。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/convert-sorted-array-to-binary-search-tree