Open
Conversation
oda
reviewed
Apr 2, 2024
| localname_prefix_no_dots = localname.split("+")[0].replace(".", "") | ||
| return localname_prefix_no_dots + '@' + domainname | ||
|
|
||
| normalized_emails = set({}) |
There was a problem hiding this comment.
set() が普通かと思います。set は iterable を引数に取ります。
https://docs.python.org/3/library/stdtypes.html#set
{} は iterable としては key の列挙なので、たしかにこれで結果は空になりますが。
oda
reviewed
Apr 2, 2024
| localnameの+より前の部分を取り出し、ピリオドを除く | ||
| e.g. m.y+name@email.com -> my@email.com | ||
| """ | ||
| localname, domainname = email.split('@') |
There was a problem hiding this comment.
split には maxsplit という引数があって、それを使うと、分割回数を制限できます。
https://docs.python.org/3/library/stdtypes.html#str.split
もちろん、今回は、問題文の制約から @ が1回しか入っていない物が来るのですが、仮に2回来たときにどのように振る舞うのが好ましいかを考えてみましょう。
Exception を投げる。
プログラムが停止する。
エラーを示す値を返す。
あたりから状況次第で決めます。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/unique-email-addresses/