small tensor parallelism optimization#796
Open
Alex-GZ wants to merge 1 commit intoturboderp-org:masterfrom
Open
small tensor parallelism optimization#796Alex-GZ wants to merge 1 commit intoturboderp-org:masterfrom
Alex-GZ wants to merge 1 commit intoturboderp-org:masterfrom
Conversation
simpler cross gpu-barrier
|
Tested it, and appears to work. Splitting 123b over 4x3090 I go from high 16/17t/s to 19.x t/s. Went back and forth a few times. Almost as good as splitting over 3 only. Should try that next and see if I get a speedup too. |
|
Some more tests. 4gpu, there is gain, 3 gpu there is about a .5t/s drop. Can you check on your setup for odd/even gpu? Maybe there is a way to use both ways depending on device count. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just two small changes in tensor parallelism:
This PR had improved generation T/s in my setup by about 20% in the zone of CUDA API queueing bottleneck (at <20k context, 123B 4.5bpw model, 6 mostly different GPU, CPU with rather slow single-threaded performance and Linux) The impact may be a bit higher on Windows, probably.