Allow explicit compatibility tensor dtype casts#167
Open
lesj0610 wants to merge 1 commit intoturboderp-org:devfrom
Open
Allow explicit compatibility tensor dtype casts#167lesj0610 wants to merge 1 commit intoturboderp-org:devfrom
lesj0610 wants to merge 1 commit intoturboderp-org:devfrom
Conversation
b8bb790 to
d98f8b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small compatibility improvement for architecture-preserving checkpoint format variation. The goal is not to support arbitrary model-specific rewrites, but to make required state tensor loading more robust when modified checkpoints keep the same module graph while changing storage dtype.
Some modified checkpoints resave required state tensors at a lower precision than the receiving op expects. This can happen after resaves, merges, abliterations, repacks, or other tooling that keeps the architecture but rewrites tensor storage or dtype.
This adds an opt-in
cast_dtypeargument toSafetensorsCollection.get_tensor()and uses it forGatedDeltaNetA_log, which the fused path expects in float.The cast is explicit, happens after materialization, and leaves unrelated tensors such as
dt_biason their current path.Adds focused tests for cast and no-cast behavior.