Add lambda function log table #177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthaI
force-pushed
the
add-lambda-function-log-table
branch
from
70f69dd to
433272e
Compare
ParthaI
force-pushed
the
add-lambda-function-log-table
branch
from
da55abd to
60c36b5
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new aws_lambda_log table to collect and structure AWS Lambda function logs from multiple sources, including S3, CloudWatch Log Groups, and generic artifact sources. Key changes include:
- Definition of
LambdaLogTablewith enrichment logic and new source metadata. - Implementation of
LambdaLogMapperto parse various Lambda log formats (S3, CloudWatch, JSON, plain text). - Comprehensive documentation and example queries for the new
aws_lambda_logtable.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tables/lambda_log/lambda_log_table.go | Introduces LambdaLogTable, source metadata, and enrich logic |
| tables/lambda_log/lambda_log_mapper.go | Implements LambdaLogMapper with parsing for multiple log formats |
| tables/lambda_log/lambda_log.go | Defines LambdaLog schema and column descriptions |
| go.mod | Bumps tailpipe-plugin-sdk and klauspost/compress versions |
| docs/tables/aws_lambda_log/queries.md | Adds 16+ example queries for the new aws_lambda_log table |
| docs/tables/aws_lambda_log/index.md | Documents table usage, message formats, and configuration |
| aws/plugin.go | Registers the new aws_lambda_log table in the plugin |
Comments suppressed due to low confidence (3)
tables/lambda_log/lambda_log_table.go:44
- This comment incorrectly labels the CloudWatch Log Group source as an S3 source. Update it to
// CloudWatch Log Group sourcefor clarity.
// S3 artifact source
tables/lambda_log/lambda_log_mapper.go:325
- There is a typo in the function name
parseLambdaPainTextLog—it should beparseLambdaPlainTextLogto match its purpose.
func parseLambdaPainTextLog(line string, log *LambdaLog) (*LambdaLog, error) {
tables/lambda_log/lambda_log_mapper.go:55
- [nitpick] This mapper contains complex handling for multiple log formats; consider adding unit tests to cover each parsing path to ensure reliability and catch future regressions.
func (m *LambdaLogMapper) Map(_ context.Context, a any, _ ...mappers.MapOption[*LambdaLog]) (*LambdaLog, error) {
| // tp_index | ||
| row.TpIndex = schema.DefaultIndex | ||
|
|
||
| var arnRegex = regexp.MustCompile(`arn:aws:[^,\s'"\\]+`) |
There was a problem hiding this comment.
Compiling the ARN regex on every row enrich call can be expensive; consider moving regexp.MustCompile to a package-level variable so it's compiled only once at startup.
| if (strings.HasPrefix(raw, "REPORT") || strings.HasPrefix(raw, "END") || strings.HasPrefix(raw, "START") || strings.HasPrefix(raw, "INIT_START") || strings.HasPrefix(raw, "EXTENSION") || strings.HasPrefix(raw, "TELEMETRY") || (isTextFormat && !isTimestamp(strings.Fields(raw)[0]) && !strings.HasPrefix(raw, "["))) && parsableJsonData == nil { | ||
| lambdaLog, err := parseLambdaPainTextLog(raw, row) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error parsing lambda pain text log: %w", err) |
There was a problem hiding this comment.
The error message contains a typo: lambda pain text log should be lambda plain text log.
…ich the row if row does not have the timestamp
ParthaI
force-pushed
the
add-lambda-function-log-table
branch
from
1628b41 to
3096098
Compare
|
@cbruno10 Would you pls review and provide feedback? |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
github-actions
bot
added
the
stale
|
This PR was closed because it has been stalled for 90 days with no activity. |
misraved
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example query results
Results