added support for data attributes if available instead of classes#21
Open
tomjn wants to merge 1 commit intotuupola:masterfrom
Open
added support for data attributes if available instead of classes#21tomjn wants to merge 1 commit intotuupola:masterfrom
tomjn wants to merge 1 commit intotuupola:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #20
If a
data-chainedattribute is present, it will be used, if it isn't, it'll fallback to the class based system currently used. This solves issues such as values containing spaces etc causing problems, without breaking existing usage.I also added parameters back into the
jQuery.eachcalls and used those instead ofthis. Also some minor optimisations by only doing$(element)once and reusing the result.