feat(macos): open Kaku with cwd from external apps#135
Merged
Conversation
- queue macOS open-path events during cold start - prefer opening external open-path in existing tab - defer default gui-startup spawn to avoid duplicate ~/ tab
nguyenphutrong
changed the title
tw93
approved these changes
Mar 3, 2026
Owner
There was a problem hiding this comment.
LGTM！
@nguyenphutrong Thanks for this contribution! I've merged your PR with a small optimization.
Your Rust-side handling with schedule_open_untitled_spawn() is well designed. The sequence-based cancellation and should_suppress_open_untitled_spawn() guard provide robust protection against duplicate tabs.
I removed the 0.8s delay in kaku.lua since the Rust-side 350ms defer mechanism is sufficient. This avoids slowing down normal startup for users who launch Kaku directly.
Thanks again for fixing this VS Code integration issue!
tw93
added a commit
that referenced
this pull request
Mar 3, 2026
The Rust-side schedule_open_untitled_spawn already handles the VS Code open-path race with a 350ms defer and sequence-based cancellation. The 0.8s Lua delay was redundant and slowed down normal startup. Refs #135
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes macOS open requests launch Kaku in the requested cwd instead of always falling back to the default
~/tab.~/tab before the cwd request arrives