feat: add golangci-lint for Go code quality #266
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should_protect_path will always be available as it comes from common.sh. This check adds a lot of overhead as it runs on every file.
… make support section collapsible
…munity love sections.
…on with new sponsorship and contribution information.
Use single quotes, otherwise this expands now rather than when signalled.
…tar size/margin, and text positioning.
…rkflow and README.
…Ds, and correct README image source path.
…in contributor workflow.
…r margin in contributor workflow.
…or the update contributors workflow.
…-command-check chore: Do not check if should_protect_path exists
…-trap fix: Use single quotes in trap
… add a contributors section.
… installer display names by stripping hash prefixes.
Bumps [stefanzweifel/git-auto-commit-action](https://github.com/stefanzweifel/git-auto-commit-action) from 5 to 7. - [Release notes](https://github.com/stefanzweifel/git-auto-commit-action/releases) - [Changelog](https://github.com/stefanzweifel/git-auto-commit-action/blob/master/CHANGELOG.md) - [Commits](stefanzweifel/git-auto-commit-action@v5...v7) --- updated-dependencies: - dependency-name: stefanzweifel/git-auto-commit-action dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…nzweifel/git-auto-commit-action-7
Fixes tw93#263 - Change regex from \.\. to (^|/)\.\.(/|$) to only match path components - Firefox uses ..files suffix in IndexedDB dirs (e.g., name..files) - Still blocks actual traversal: /tmp/../etc - Added test cases for Firefox compatibility - All 16 tests passing
- Add .golangci.yml configuration enabling govet, staticcheck, errcheck, gosimple, ineffassign, unused, gofmt, and goimports linters - Update scripts/check.sh to run golangci-lint with go vet fallback - Update CI workflow to install golangci-lint in both format and quality jobs - Add golangci-lint to CONTRIBUTING.md setup instructions Sensible exclusions configured for test files and common patterns (os.Remove, deferred Close calls).
Owner
|
@anonymort It seems that the code you submitted has some historical issues. Try submitting only the code you have modified. It should be that the code needs to be synchronized to the latest first, and then submitted. |
alexandear
reviewed
Jan 6, 2026
Contributor
There was a problem hiding this comment.
This configuration file targets Golangci-lint v1, which is deprecated and incompatible with v2. We should use the latest version (v2.7.2) instead. See https://golangci-lint.run/
Contributor
Did you intend to tag me? |
Owner
|
@JackPhallen sorry 😞 I made a mistake |
Owner
|
I recently made some modifications myself, thank you for submitting the contribution code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.golangci.ymlconfiguration enabling govet, staticcheck, errcheck, gosimple, ineffassign, unused, gofmt, and goimports lintersscripts/check.shto run golangci-lint with go vet fallbackChanges
.golangci.ymlscripts/check.sh.github/workflows/check.ymlCONTRIBUTING.mdDetails
go vetif golangci-lint is not installed locallyTest plan
./scripts/check.shruns without errors