Merged
Conversation
Gipphe
force-pushed
the
gipphe/chore-enable-more-ghc-warnings
branch
from
a6e4204 to
0bdd85b
Compare
Gipphe
force-pushed
the
gipphe/chore-enable-more-ghc-warnings
branch
from
0bdd85b to
ffa9077
Compare
Some exceptions have to be made for `base` and `tasty-discover` though.
Gipphe
force-pushed
the
gipphe/chore-enable-more-ghc-warnings
branch
from
ffa9077 to
8bcbbfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
-Weverythingand selectively disable warnings we don't want instead of using-Walland adding missing ones.Warnings worth mentioning:
-Wderiving-typeable:Typeableis now automatically derived for all types in Haskell since GHC 7.10. Explicitly deriving it in aderivingclause is redundant.-Wmissing-deriving-strategies: Makes it more explicit how we are deriving instances for all types. Adds a bit of overhead, but makes it more explicit how instances are derived by enforcing thestock,newtype,anyclassorviastrategies to be stated.-Wunused-packages: We would normally like to enable this by default, but currentlybaseandtasty-discoverare considered "unused" by it, and are thus falsely flagged. This creates unnecessary noise in the compiler output, so it is wise to instead use this on a "by need" basis instead.Some other warnings we instead explicitly disable. The reason for disabling each of them is stated in a comment next to the respective GHC option flag.