refactor: extract more code into atelier library#339
Merged
Conversation
Gipphe
reviewed
Mar 18, 2026
Gipphe
approved these changes
Mar 18, 2026
Collaborator
Gipphe
left a comment
Gipphe
left a comment
There was a problem hiding this comment.
Drop prompt.md, and this is good to go!
cgeorgii
force-pushed
the
refactor/atelier-pt2
branch
from
e1d4ca9 to
1db2146
Compare
- **`Atelier.Component`** — component lifecycle (`setup`/`listeners`/`triggers`/`start`); all callers updated to import directly - **`Atelier.Effects.DB`** — unified `DBRead`/`DBWrite` effects (mirroring `Pub`/`Sub` in a single module) with `runDB`, `runDBRead`, `runDBWrite`, and `DBReadMetricNames`; replaces separate `DBRead`/`DBWrite` modules; `Hoard.Effects.DB` pre-fills hoard-specific metric names - **`Atelier.Effects.DB.Config`** — `DBConfig`, `DBPools`, `PoolConfig`, pool acquisition helpers; callers updated to import directly - **`Atelier.Config`** — generic JSON config utilities: `envOverrides`, `deepMerge`, `LoadedConfig`, `runConfig`; `Hoard.Effects.ConfigPath` retains only the hoard-specific loader and `runConfigRoot`
cgeorgii
force-pushed
the
refactor/atelier-pt2
branch
from
1db2146 to
7f385c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Atelier.Component— component lifecycle (setup/listeners/triggers/start); all callers updated to import directlyAtelier.Effects.DB— unifiedDBRead/DBWriteeffects (mirroringPub/Subin a single module) withrunDB,runDBRead,runDBWrite, andDBReadMetricNames; replaces separateDBRead/DBWritemodules;Hoard.Effects.DBpre-fills hoard-specific metric namesAtelier.Effects.DB.Config—DBConfig,DBPools,PoolConfig, pool acquisition helpers; callers updated to import directlyAtelier.Config— generic JSON config utilities:envOverrides,deepMerge,LoadedConfig,runConfig;Hoard.Effects.ConfigPathretains only the hoard-specific loader andrunConfigRoot