Closed
Conversation
Collaborator
There was a problem hiding this comment.
If all these things are commented out we will be on our own to find them back again to remove them later. It comes down to whether we prefer that over having to ignore warnings + failed CI runs. I feel inclined to the latter, as these are not exactly the same CI runs that we have to clear upstream.
I've just added this in cabal.project.local in cardano-node
program-options
ghc-options: -Wwarn -Wno-unused-packages -Wno-unused-importsIt alliviates the most annoying. Then I'ld wait until upstream editing to use -Werror.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently there are build failures on the conformance-testing branch due to the elevation of warnings to errors, because some code is temporarily commented out. (Unused imports, unused dependencies, redundant constraints.) This will be fixed, but in the meantime this patch comments out the offending imports.