Merged
Conversation
adithyaov
reviewed
Feb 26, 2026
dev-local/Populate.hs
Outdated
| quoted = show | ||
|
|
||
| optString :: String -> String -> CmdOption | ||
| optString a b = CoOpt a b |
Member
There was a problem hiding this comment.
Why not just use opt?
Does quoting affect anything?
Collaborator
Author
There was a problem hiding this comment.
It would be cool if you test it as well, because it might be linux thing but maybe I'm wrong.
At least for me, I've tried manually to run cardano-testnet and it just ignores paths in quotes.
adithyaov
approved these changes
Feb 26, 2026
axman6
approved these changes
Feb 27, 2026
Comment on lines
+258
to
+265
| runCmd | ||
| "cardano-testnet create-env" | ||
| [ opt "num-pool-nodes" env_CARDANO_TESTNET_NUM_NODES | ||
| , flg "enable-new-epoch-state-logging" | ||
| , optString "output" env_TESTNET_WORK_DIR | ||
| , opt "testnet-magic" env_CARDANO_TESTNET_MAGIC | ||
| ] | ||
| & Console.putChunks |
Contributor
There was a problem hiding this comment.
Is there any problem runing this moire than once? I guess we always want to start fresh
Collaborator
Author
There was a problem hiding this comment.
As I can see it just ignores and doing nothing if it already exists. But we might want to clean up before running it (not sure if it's necessary, since we don't change it anyway).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.