Open
Conversation
adithyaov
commented
Mar 5, 2026
| res <- C.executeLocalStateQueryExprLeashed conn leashId False (Net.Query.SpecificPoint cp) query | ||
| runLocalStateQueryExprWith refLeashPoint conn leashId cp shouldRelease query = do | ||
| IORef.atomicModifyIORef refLeashPoint (const (Just cp, ())) | ||
| res <- C.executeLocalStateQueryExprLeashed conn leashId shouldRelease (Net.Query.SpecificPoint cp) query |
Member
Author
There was a problem hiding this comment.
We should bracket this.
Side note: This seems a little hacky. Is there a better alternative to sync this with the state of the node?
tweag-ev-ak
approved these changes
Mar 6, 2026
Collaborator
tweag-ev-ak
left a comment
tweag-ev-ak
left a comment
There was a problem hiding this comment.
LGTM!
Please don't merge yet. I want to think about the ouroboros-consensus side more.
axman6
reviewed
Mar 9, 2026
Contributor
axman6
left a comment
axman6
left a comment
There was a problem hiding this comment.
I'm not sure I fully understand this one, and I think it might be better to leave this untill we have abetter understanding of how rollbacks will be handled by the PSR.
axman6
reviewed
Mar 13, 2026
| Nothing -> pure () | ||
| Just cp -> | ||
| void $ | ||
| runLocalStateQueryExprWith leashRef conn leashId cp True sysStartQuery |
Contributor
There was a problem hiding this comment.
Is the sysStartQuery here just used as a no-op query? I have a feeling you can just use pure () since queries are Applicatives.
Member
Author
There was a problem hiding this comment.
Indeed that's a great suggestion!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Endpoints:
TODO: