Skip to content

fix(cli): avoid bootstrap checks when trying to reset-wal#949

Merged
scarmuega merged 1 commit intomainfrom
fix/reset-wal-cmd
Mar 18, 2026
Merged

fix(cli): avoid bootstrap checks when trying to reset-wal#949
scarmuega merged 1 commit intomainfrom
fix/reset-wal-cmd

Conversation

@scarmuega
Copy link
Member

@scarmuega scarmuega commented Mar 18, 2026

Summary by CodeRabbit

  • Refactor
    • Improved internal architecture for state and storage management to enhance code maintainability and organization.

@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Updated the reset_wal doctor command to access state and WAL stores directly via open_state_store() and open_wal_store() functions instead of through a domain object. The control flow and functionality remain unchanged.

Changes

Cohort / File(s) Summary
WAL Reset Refactoring
src/bin/dolos/doctor/reset_wal.rs
Replaced domain-based state and WAL access with direct store access via open_state_store(config) and open_wal_store(config). Updated references from domain.state and domain.wal() to use the new store variables directly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A little hop through refactoring's dance,
Where stores now open at first glance,
No domain walls need stand in the way,
Just clean WAL wiring—hip hip hooray!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title claims the fix avoids bootstrap checks, but the summary shows only internal refactoring to use new store accessors, with no visible control flow changes related to bootstrap checks. Clarify whether the bootstrap check avoidance is achieved through the refactored store access, or if additional implementation details are needed to verify this claim.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/reset-wal-cmd
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@scarmuega scarmuega merged commit 42cf220 into main Mar 18, 2026
11 of 12 checks passed
@scarmuega scarmuega deleted the fix/reset-wal-cmd branch March 18, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant