Clean up dependencies #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure who thought the imports are specific to mtl >=2.3
base >=4.11 (GHC >=8.4) because in GHC 8.2, Data.Monoid.<> and Data.Semigroup.<> used to be different identifiers, and then became one identifier. This change is difficult to support and not worth it IMO. fast-logger >=2.4.11 because that's when Show LogStr was introduced, which we use.
Yuras
approved these changes
Oct 9, 2025
odr
approved these changes
Oct 14, 2025
| Control.Logger.Katip.Utils | ||
| Control.Logger.Orphans | ||
|
|
||
| exposed-modules: Control.Logger.Internal |
There was a problem hiding this comment.
it looks strange... I don't see any deps from control-logger in hotels/portal frontend at all...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know what happened there with
MIN_VERSION_mtl(2,3,0), but it prevented compilation on older GHCs, removing it fixes compilation, and I don't get any unused import warnings, across all GHC and mtl versions.The package now builds against all dependency versions that can be planned, given the fixes in this PR:
base >=4.11(GHC >=8.4) because in GHC 8.2,Data.Monoid.<>andData.Semigroup.<>used to be different identifiers, and then became one identifier. This change is difficult to support and not worth it IMO.fast-logger >=2.4.11because that's when Show LogStr was introduced, which we use.