Skip to content

Conversation

@iRevive
Copy link
Contributor

@iRevive iRevive commented Oct 24, 2022

The follow-up to #3128. The original PR has been stale for some time :(

@iRevive
Copy link
Contributor Author

iRevive commented Oct 24, 2022

It seems this change is binary breaking.

Is it safe to add ProblemFilters.exclude[ReversedMissingMethodProblem]("cats.effect.IOLocal.scope") to MiMa exclusions? Or do I need to add trait IOLocalBincompat1 instead?

@armanbilge
Copy link
Member

It is safe to add the exclusion, because IOLocal is a sealed trait. That means we can add abstract methods to it without breaking implementors, since we control all the implementations.

@iRevive
Copy link
Contributor Author

iRevive commented Oct 25, 2022

Hm, for some reason, GitHub does not recognize my changes in this branch anymore. I made a new PR instead - #3214.

@iRevive iRevive closed this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants