Create core module #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Aug 23, 2021
| import cats.effect.kernel.Deferred | ||
| import cats.syntax.all._ | ||
|
|
||
| private[feral] trait IOSetup { |
Member
Author
There was a problem hiding this comment.
Do we want to expose this outside of feral?
Comment on lines
+30
to
+32
| protected def setup: Resource[IO, Setup] = Resource.pure(null.asInstanceOf[Setup]) | ||
|
|
||
| private[feral] final lazy val setupMemo: IO[Setup] = { |
Member
Author
There was a problem hiding this comment.
@djspiewak: @bpholt and I changed this to def / lazy val to avoid initialization errors, undoing your change in #1 to make setup a val. Is there a better way to handle this?
bpholt
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cherry-picked out of #4. Creates a core module containing
IOSetupto abstract the one-time-resource-acquisition logic.