Implement tag filtering #234
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filosganga
commented
Oct 16, 2025
modules/core/shared/src/main/scala/weaver/internals/TagExprParser.scala
Outdated
Show resolved
Hide resolved
filosganga
commented
Oct 16, 2025
Comment on lines
+66
to
+70
| def unsafeFromPattern(pattern: String): Wildcard = | ||
| fromPattern(pattern).leftMap { e => | ||
| new RuntimeException( | ||
| s"The pattern: ${pattern} is not a valid tag wildcard. ${e}") | ||
| }.fold(throw _, identity) |
Author
There was a problem hiding this comment.
This is almost only for testing purposes, we could use literally instead as, for testing, the pattern is always known at compile time
majk-p
reviewed
Oct 17, 2025
modules/core/shared/src/main/scala/weaver/internals/TagExpr.scala
Outdated
Show resolved
Hide resolved
modules/core/shared/src/main/scala/weaver/internals/TagExpr.scala
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks @filosganga ! I've added some ideas to the issue #233 (comment), suggesting that we improve support for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to achieve #233.
Summary
This PR adds tag-based test filtering using GitHub's label filtering syntax with wildcard pattern matching support. Users can now filter tests by tags using the
-t/--tagsflag with expressive boolean logic and wildcards.Changes
Core Implementation
TagExpr.scala- Tag expression AST withAtom,Wildcard,Not,And,OrnodesGithubTagExprParser.scala- Parser for GitHub-style syntax (replaces PyTest-styleTagExprParser),for OR operator!for NOT operator()for groupingWildcardpattern matching - Using cats-parse combinators*matches zero or more characters?matches exactly one characterbug-*,*-prod,first*bug,test-?Filters.scala- Integration with existing filtering infrastructureTests
TagExprTests.scala- Comprehensive wildcard pattern parsing and matching testsGithubTagExprParserTests.scala- Parser syntax tests with GitHub-style expressionsDocumentation
filtering.md- Complete guide on pattern and tag-based filteringtagging.md- How to add tags and naming conventions.tagged()method usage.ignoreand.onlyREADME.md- Overview of the new tag filtering featureBreaking Changes
-o/--only) continues to work unchanged.tagged(),.ignore,.only) continues to work unchangedDependencies
cats-parsefrom0.3.10to1.0.0(required for.soft/.backtrackAPIs)Examples
Run tests tagged as "bug" OR "feature":
Run tests tagged as both "integration" AND "database":
Run all tests except "slow" ones:
Run bug-related tests, excluding wontfix:
Run all tests matching bug-* pattern:
Run tests matching environment pattern:
Complex expression with grouping:
Combine tag and pattern filters: