Skip to content

Conversation

@byronwilliams
Copy link

Change Summary

  • Include pages for a collection by the use of a tag selector

PR Checklist

resolve: `gatsby-plugin-typesense`,
options: {
rootDir: `${__dirname}/public`, // Required
includeTags: { "data-typesense-model": "product" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word includeTags almost makes it sound like these are the only tags that will be indexed by the plugin. How about calling it something like includePagesWithTags.

Also, I know the tag name here is just an example, but it makes it sound like it configures the Typesense Collection that the page is indexed to. How about we have the example as:

includePagesWithTags: {"data-typesense-include-page": "product"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants