-
-
Notifications
You must be signed in to change notification settings - Fork 12
feat!: add v30 api breaking changes #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
lib/typesense/analytics_rules.rb
Outdated
| end | ||
|
|
||
| private | ||
| def respond_to_missing?(_method_name, _include_private = false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks the pattern we have in all the other resources for array access. Any reason you added it just for this and the new resources?
I'd prefer we not add it, so there's only one way to access individual objects across all types of resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed in b728531
Change Summary
Integrate the new v30 breaking API changes into the client.
Those include:
synonym_setscuration_setsPR Checklist