fix: group_by with hybrid search when no keyword matches exist#2738
Open
ozanarmagan wants to merge 7 commits intotypesense:v31from
Open
fix: group_by with hybrid search when no keyword matches exist#2738ozanarmagan wants to merge 7 commits intotypesense:v31from
ozanarmagan wants to merge 7 commits intotypesense:v31from
Conversation
Member
|
Fixes #2723 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
When hybrid search with group_by has no keyword matches, since
raw_results_kvsis empty, we don't do the second pass. However, we fetch the results of the vector search in second pass when doing hybrid search. This PR updates early exit logic by adding an extra condition by checking if it is hybrid search.PR Checklist