Draft
Conversation
Contributor
|
CC: @kishorenc |
Contributor
|
Is this ready for review? |
Author
|
New contributor, so I just wanted a review of this draft before submitting as PR in case of any obvious pitfalls Let me know if I should just submit as PR, I think repo does not run clean build on issue of draft PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: infix filtering support (field:value) #2685
Closes #2685
Typesense supports exact (field:value) and prefix (field:value*) filtering on string fields, but had no way to filter by substring , users couldn't express "give me all docs where this field contains this value."
This PR adds field:value syntax to filter_by, enabling infix/contains filtering on string and string array fields that have
infix: truein their schema.Changes:
are intersected (AND). Multiple filter values in a list (e.g. [foo, bar]) are OR'd together.
Tesing (CollectionFilteringTest.InfixFilterOnTextFields)