feat(vector-search): make secondary sort stable within distance buckets#2833
Open
nkneupper wants to merge 1 commit intotypesense:v31from
Open
feat(vector-search): make secondary sort stable within distance buckets#2833nkneupper wants to merge 1 commit intotypesense:v31from
nkneupper wants to merge 1 commit intotypesense:v31from
Conversation
When using _vector_distance(buckets: N) or _vector_distance(bucket_size: N), results within the same bucket were being reordered by document key as a tiebreaker, disrupting the original vector distance ordering when secondary sort values were equal. Add is_greater_kv_group_stable (without the key tiebreaker) so that std::stable_sort preserves the pre-bucket ordering when scores are tied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using _vector_distance(buckets: N) or _vector_distance(bucket_size: N), results within the same bucket were being reordered by document key as a tiebreaker, disrupting the original vector distance ordering when secondary sort values were equal. Add is_greater_kv_group_stable (without the key tiebreaker) so that std::stable_sort preserves the pre-bucket ordering when scores are tied.
My product use case for this stable sort is to utilize the secondary sort as a kind of "search boost". The vector distance is the primary sort, but within each bucket, a secondary sort can apply to locally boost certain results within that bucket.
I am open to feedback and would be willing to explore an interface change to optionally make this secondary sort stable rather than having it stable by default (e.g.
sort_by: _vector_distance(bucket_size: 25):asc, boost_score:asc:stable)Change Summary
PR Checklist