add custom line numbers#32
Merged
quachpas merged 6 commits intotypst-community:mainfrom Nov 23, 2025
JL710:main
Merged
Conversation
Collaborator
|
Hi @JL710, thanks for the patch. Can you add a test, corresponding documentation to the README please? The added info should be copied into the NEWS.md as well. |
Contributor
Author
|
@quachpas I added/updated a unittest and added documentation. Since I never worked with tytantic before I tried my best with the unittest. You might want to special check the unittest changes. |
Collaborator
|
Thanks, that's perfectly fine I'll check it on my side |
quachpas
requested changes
Nov 13, 2025
Collaborator
quachpas
left a comment
There was a problem hiding this comment.
I've reviewed the patch. Thank you, it looks nice and I'll be glad to merge this ! I've left comments in the PR for you to look at.
quachpas
requested changes
Nov 15, 2025
Collaborator
quachpas
left a comment
There was a problem hiding this comment.
Thank you! I've reviewed the new changes, and that should be the final review. After this, I will merge this.
… test for line-numbers-format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to pass a function that takes a line number and returns content to the line-numbers parameter. Thus allowing users to style the line numbers as they wish.
Example