fix: error on target platform != x86_64-unknown-linux-gnu#9
Open
haenoe wants to merge 1 commit intotypst:mainfrom
Open
fix: error on target platform != x86_64-unknown-linux-gnu#9haenoe wants to merge 1 commit intotypst:mainfrom
haenoe wants to merge 1 commit intotypst:mainfrom
Conversation
Ensure `RUSTFLAGS` is not `null`, when target platform is not x86_64-unknown-linux-gnu but rather `""`. Note that as per https://doc.rust-lang.org/cargo/reference/config.html#buildrustflags an empty RUSTFLAGS still overrides user configuration (e.g. in cargo config).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, thanks a lot for maintaining this! Hope you don't mind me skipping the issue step.
When trying to use this flake on Darwin, I ran into the following error:
This is due the fact that
RUSTFLAGSis set tonull, when target !=x86_64-unknown-linux-gnusee hereRelevant check in
nixpkgsMinor note: as per https://doc.rust-lang.org/cargo/reference/config.html#buildrustflags an empty
RUSTFLAGSstill overrides user configuration (e.g. in cargo config); see this