feature: Add persistent notification for wireless pairing (Fixes non-split-screen pairing)#141
Open
Golgrax wants to merge 1 commit intotytydraco:mainfrom
Open
feature: Add persistent notification for wireless pairing (Fixes non-split-screen pairing)#141Golgrax wants to merge 1 commit intotytydraco:mainfrom
Golgrax wants to merge 1 commit intotytydraco:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a major UX barrier for devices that do not support split-screen or floating windows.
This new feature allows the user to complete the entire pairing and connection process directly from the notification shade while the Developer Options screen remains open in the foreground.
Key Features
Two-Step Stateful Pairing:
Step 1: User inputs the Port (or IP:Port) via the notification.
Step 2: The notification updates to ask for the Pairing Code.
The app statefully remembers the port between steps, providing a clean, conversational flow.
Real-time Feedback: Displays actual output logs from the ADB command in the notification text (e.g., "Successfully paired" or real error messages like "Wrong password").
Automatic Connection: Immediately triggers mDNS discovery and initServer() upon successful pairing, ensuring the app is connected and ready to use as soon as the user returns to it.
Dynamic UI: The input field and "Enter" button automatically disappear once the status reaches "Connected!", leaving a clean confirmation message.
Retry Mechanism: If pairing fails, a "Retry" action button appears to reset the flow without needing to reopen the app.
Sample Testing
View Screenshots
Allow it.