Skip to content

Update to ruby 3.3.10#910

Merged
jefferya merged 1 commit intomainfrom
ruby_3.3.10
Jan 20, 2026
Merged

Update to ruby 3.3.10#910
jefferya merged 1 commit intomainfrom
ruby_3.3.10

Conversation

@jefferya
Copy link
Contributor

No description provided.

Copy link
Contributor

@lagoan lagoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is great that you created this PR to get the version updated!

I did not have any problems with the test suite and did some manual testing. It was a bit difficult to do the manual test with the current state of the seeds since a lot of pages are not ingested. Did you have any issues testing ? I know you would have been missing the same pages since it is a problem in the CMS gem inteself.

@jefferya
Copy link
Contributor Author

I did not have any problems with the test suite and did some manual testing. It was a bit difficult to do the manual test with the current state of the seeds since a lot of pages are not ingested. Did you have any issues testing ? I know you would have been missing the same pages since it is a problem in the CMS gem inteself.

The automated tests are minimal (:shrug:) so I had no problems. I wonder if #885 and updating the seeds will help (for example, are the hierarchical organizations different?). I've included a point in the issue #898 suggesting a test improvement task.

Copy link
Contributor

@lagoan lagoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buen trabajo!

@jefferya jefferya merged commit 8a133a3 into main Jan 20, 2026
2 checks passed
@jefferya jefferya deleted the ruby_3.3.10 branch January 20, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants