This repository was archived by the owner on Jan 31, 2018. It is now read-only.
bump bignum to 0.11.0 to allow compilation on node v4.x and v5.x #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
+1; Please verify correctness in kafka-logger tests upstream (the only tests I know off that actually integration test over TCP with binary kafka protocol, i dont trust the tests in Prozess or Nodesol themself...) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bignum 0.9.2 fails compilation on node 5.3.0 with the following errors:
https://gist.github.com/lxe/bf2aa2c001c2db06c815
Bumping bignum version in an attempt to fix these errors.
ref: cainus#55